On 25/02/02 10:52AM, Phillip Wood wrote: > Hi Justin > > On 01/02/2025 20:16, Justin Tobler wrote: > > The `quote_path()` function invokes `quote_c_style_counted()` to handle > > quoting. This means the output `quote_path()` is ultimately affected by > > `core.quotePath` configuration. In a subsequent commit, `quote_path()` > > will be used in a scenario where the output should remain consistent > > regardless of the current configuration. > > > > Introduce the `QUOTE_PATH_IGNORE_CONFIG` flag for `quote_path()`which > > when set instructs the underlying `quote_c_style_counted()` to also > > ignore the `core.quotePath` configuration when executed. > > I'm confused as to why this is necessary. All of our existing plumbing > commands that print paths respect core.quotePath so why is rev-list > different? The config setting only affects the representation used for bytes > 0x80 and above, control characters, backslash and double-quote are always > quoted. You are correct that it isn't neccesary. From a previous discussion, I initally thought it would preferrable to have consistent output for this plumbing operation, but as you pointed out other plumbing commands respect core.quotePath. I'll drop these first two patches in the next version. Thanks for the feedback! -Justin
