On Sun, Feb 2, 2025 at 7:09 AM ayu-ch <ayu.chandekar@xxxxxxxxx> wrote:
> Some test in t6423 supress Git's exit code, which can cause test
> failures go unnoticed. Specifically using git <subcommand> |
> <other-command> masks potential failures of the Git command.
>
> This commit ensures that Git's exit status is correctly propogated by:
> - Avoiding pipes that suppress exit codes.
>
> Signed-off-by: Ayush Chandekar <ayu.chandekar@xxxxxxxxx>
> ---
> diff --git a/t/t6423-merge-rename-directories.sh b/t/t6423-merge-rename-directories.sh
> @@ -5071,7 +5071,8 @@ test_expect_success '12i: Directory rename causes rename-to-self' '
> - git ls-files | uniq >tracked &&
> + git ls-files >actual &&
> + uniq <actual >tracked &&
I was curious if the project has a preference between `uniq filename`
and `uniq <filename`, but apparently we haven't:
% git grep 'uniq <' -- t | wc -l
2
git grep 'uniq [a-z0-9]' -- t | wc -l
2
Though there does seem to be a global preference in the project to
specify the filename directly to the command rather than redirecting
from stdin. For instance:
% git grep 'sort <' -- t | wc -l
54
% git grep 'sort [a-z0-9]' -- t | wc -l
140
In any case, what you have here is probably fine, so no need to reroll
just for this.
