On Wed, Jan 22, 2025 at 05:52:30PM -0800, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > Since this hit 'next', it made it into my Coverity runs, producing the > > small fixup below. > > Thanks. A greedy me wonders if things like this can be caught by > them a bit earlier before they hit 'next', though ;-) I've always been a little afraid to touch 'seen' since it does not necessarily even pass tests, and I don't want to waste too much time hunting problems in other people's topics. ;) But I might give it a try. It will require some workflow changes, as I only run CI on what I integrate for my daily build, which is based on next. I do not ever look at or push what is in 'seen' at all to my repo. Hmm. I wonder if I could just build my daily driver off of 'jch', which is a little less scary than 'seen' (and IIRC is your daily driver?). > Nice way to use extended context to show why the change makes sense. I've been tempted to support a: Diff-options: -U10 trailer, but that is probably overkill and full of annoying corner cases. -Peff