Seyi Kuforiji <kuforiji98@xxxxxxxxx> writes: > Hello, > > This small patch series transitions the existing unit test files to the > Clar testing framework. This change is part of our ongoing effort to > standardize our testing approach and enhance maintainability. > > Changes in v2: > - small fixes to the commit messages and how they read > - some small code fix up and refactoring > > Thanks > Seyi > > Mentored-by: Patrick Steinhardt ps@xxxxxx > Signed-off-by: Seyi Kuforiji kuforiji98@xxxxxxxxx > > Seyi Kuforiji (4): > t/unit-tests: convert hashmap test to use clar test framework > t/unit-tests: adapt example decorate test to use clar test framework > t/unit-tests: convert strbuf test to use clar test framework > t/unit-tests: convert strcmp-offset test to use clar test framework Overall they looked quite straight-forward rewrite. Nicely done. Queued with automated fix-ups, so there is no need to resend only to fix below. Thanks. Applying: t/unit-tests: convert hashmap test to use clar test framework Applying: t/unit-tests: adapt example decorate test to use clar test framework .git/rebase-apply/patch:105: indent with spaces. * In case the buffer contains anything, `alloc` must alloc must .git/rebase-apply/patch:106: indent with spaces. * be at least one byte larger than `len`. .git/rebase-apply/patch:107: indent with spaces. */ .git/rebase-apply/patch:109: indent with spaces. cl_assert(buf->len < buf->alloc); warning: 4 lines add whitespace errors. Applying: t/unit-tests: convert strbuf test to use clar test framework Applying: t/unit-tests: convert strcmp-offset test to use clar test framework