Re: [RFC PATCH resend] builtin/repack: Honor --keep-pack and .keep when repacking promisor objects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2025-01-29 at 10:02:06, Tomáš Trnka wrote:
> diff --git a/builtin/repack.c b/builtin/repack.c
> index d6bb37e84a..fe62fe03eb 100644
> --- a/builtin/repack.c
> +++ b/builtin/repack.c
> @@ -388,15 +388,23 @@ static int has_pack_ext(const struct generated_pack_data 
> *data,
>  }
>  
>  static void repack_promisor_objects(const struct pack_objects_args *args,
> -				    struct string_list *names)
> +				    struct string_list *names,
> +				    struct string_list 
> *keep_pack_list)

I don't have a strong opinion about the technical aspects of this patch
(nor sufficient knowledge to review it)[0], but I noticed that there's a
couple of places, this line among them, which are unexpectedly wrapped,
so I don't believe this patch will actually apply.  I noticed that the
email didn't specify an MUA header (or I missed it), so I can't make a
suggestion on how to fix your MUA, but you may want to use `git
send-email` to avoid this problem in the future.

[0] In other words, no need to CC me on a resend.
-- 
brian m. carlson (they/them or he/him)
Toronto, Ontario, CA

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux