Patrick Steinhardt <ps@xxxxxx> writes: > On Tue, Jan 28, 2025 at 02:48:42PM -0800, Junio C Hamano wrote: >> Patrick Steinhardt <ps@xxxxxx> writes: >> >> > Changes in v2: >> > - The splitup of Windows headers has broken compilation because some >> > of the headers couldn't be found anymore. I've fixed this more >> > generally by converting includes in "compat/" to always be relative >> > to the project source directory, dropping the platform-specific >> > `-Icompat/` include. >> >> Nice. >> >> Use of -Icompat/plat/ would make more sense if our sources include >> a header file using the standard name of a file that usually appear >> in /usr/include/ on a platform that either lacks /usr/include/foo.h >> or whose /usr/include/foo.h is inadequate by giving a replacement >> definition in compat/plat/foo.h we ship. But that is not how we use >> them, so I very much like this change. > > We still do that for drop-in replacements like "compat/regex" or > "compat/poll", but for everything else we stop doing it. Yup.
