Patrick Steinhardt <ps@xxxxxx> writes: >> diff --git a/date.c b/date.c >> index a1b26a8dce..0a3fafc8a4 100644 >> --- a/date.c >> +++ b/date.c >> @@ -1270,8 +1270,8 @@ static const char *approxidate_alpha(const char *date, struct tm *tm, struct tm >> >> tl = typelen; >> while (tl->type) { >> - int len = strlen(tl->type); >> - if (match_string(date, tl->type) >= len-1) { >> + size_t len = strlen(tl->type); >> + if (match_string(date, tl->type)+1 >= len) { > > Formatting is off here, there should be spaces around `+`, even though > you simply followed previous style. It would be nice to point out why > this change is makde in the commit message. I think len-1 here is perfectly fine, as there is no element in typelen[] whose .type member is an empty string, and no need to touch that. Besides, we already have this one in 'next'. Thanks.