On Fri Jan 24, 2025 at 17:07, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Patrick Steinhardt <ps@xxxxxx> writes: > >>> diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh >>> index 2d9587059f..cfa63ae086 100755 >>> --- a/t/t5510-fetch.sh >>> +++ b/t/t5510-fetch.sh >>> @@ -84,6 +84,19 @@ test_expect_success "fetch test remote HEAD" ' >>> branch=$(git rev-parse refs/remotes/origin/main) && >>> test "z$head" = "z$branch"' >>> >>> +test_expect_success "fetch test remote HEAD in bare repository" ' >>> + cd "$D" && >>> + git init --bare barerepo && >>> + cd barerepo && >> >> The `cd` needs to happen in a subshell. ALso, the same comment here >> regarding whether we want to have `test_when_finished` to clean up >> state. > > Yes, indeed. The change to another script we saw earlier followed > the "chdir around only in a subshell" pattern. > >> I see though that you simply follow existing code style, both for the >> call to cd(1) and for the single-quote, so these are fine. This test >> file could use a makeover, but that is obviously outside of the scope of >> this patch series. > > Terminating quote can stay, but chdir is a correctness issue that > may want to be addressed minimally (i.e. not making things worse, > while leaving it for later to clean up the existing ones). I'll be sending the fix with also the terminating quote fixed as well. Actually tests after this which I added for followremotehead followed the correct style so why not here as well ... 5505 remote also has some style issues that came up before so if I find some time I'll probably send a patches cleaning the up both. > > Thanks. -- bence.ferdinandy.com
