Mike Hommey <mh@xxxxxxxxxxxx> writes: >> So the earlier part of the test >> >> GIT_EDITOR=cat git tag -a initial-comment > actual || true && >> >> is already bogus with respect to the latter point. It will >> happily continue if "git tag" erroneously returns success, and >> the above does not catch it. >> >> if GIT_EDITOR=cat git tag -a initial-comment >actual >> then >> echo >&2 oops we should have errored out >> false >> else >> : happy -- anything else we want to check? >> fi > > This should probably be tested in another test block. Fair enough; please make it so. > Which is roughly what my patch does, except it doesn't check for > ordering. ... which I think is more important part. If the blank like were at the end, that would be irritating for the user, wouldn't it? - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
