On Fri, Jan 10, 2025 at 12:32 PM Patrick Steinhardt <ps@xxxxxx> wrote: > Fix the issue by generating a couple thousand nested submodules and > matching on the first nested submodule. This ensures that the recursive > git-submodule(1) process completely fills its stdout buffer, The patch looks great to me and I like the previous discussion with Peff about it. I just want to say that, after reading the discussion and then this paragraph, I wondered if it would have been possible to instead have a `test-tool submodule` helper that would behave the same as `git submodule` except that it would call setvbuf() to reduce the size of the stdout buffer. This might have allowed a test that didn't need 2000 nested submodules, and thus might have been faster. No need to change anything though. > which makes > subsequent writes block until the downstream consumer of the pipe either > reads more or closes it.
