Karthik Nayak <karthik.188@xxxxxxxxx> writes: > Junio C Hamano <gitster@xxxxxxxxx> writes: > >> * kn/reflog-migration-fix (2025-01-15) 1 commit >> (merged to 'next' on 2025-01-16 at ae8f9ce9a0) >> + reftable: write correct max_update_index to header >> (this branch is used by kn/reflog-migration-fix-followup.) >> >> "git refs migrate" for migrating reflog data was broken. >> >> Will merge to 'master'. >> cf. <Z4mUizLNUdq_1BgY@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> >> source: <CAOLa=ZTL9n_DPhNr49XAd6bT838kc09oVx_AH7Pb4o8VK_xQ9w@xxxxxxxxxxxxxx> > > This seems to be breaking on 'next'. I tested it locally with > > GIT_TEST_DEFAULT_REF_FORMAT=reftable meson test -v --test-args='-i' t1400-update-ref > > my local tests were made on files backend, and it didn't trigger on the > CI either for some reason (I shall investigate that soon). But dscho > (CC'd) reported that macos builds for reftable were failing [1] for his > branch and I could bisect it to this. > > I'm yet to understand why this fails and also why the CI didn't notify > of the issue. But that is something I shall do next. For now we need to > remove it from next. > > [1]: https://github.com/dscho/git/actions/runs/12906424058/job/35987723223 This is reproducible when the leak sanitizier is enabled and tested against reftable: So setting up meson with: CC=clang meson setup --reconfigure -Db_sanitize=address,undefined build and running the test in the build folder with: GIT_TEST_DEFAULT_REF_FORMAT=reftable meson test -v --test-args='-ixd' t1400-update-ref reproduces the issue. I haven't found the root cause yet, but will mostly call it a day and get back to this tomorrow. Karthik
Attachment:
signature.asc
Description: PGP signature
