Usman Akinyemi <usmanakinyemi202@xxxxxxxxx> writes:
> Yeah, that is true, I could not notice this as the next commit of the
> patch series
> was able to fix it. I will change it to "echo", with this, it will be better.
If we want to prepare ourselves against any arbitrary garbage the
builder may throw at us, using printf with _fixed_ format and feed
the potentially arbitrary garbage as its parameter to be
interpolated is the safest approach, so writing it as
printf "agent=git/%s\n" "$(git version | cut ...)"
would signal the readers that whoever wrote it knew what they were
doing and was being extra careful.
THanks.
