On Mon, Jan 20, 2025 at 05:07:23AM -0500, Karthik Nayak wrote: > Patrick Steinhardt <ps@xxxxxx> writes: > > > Hi, > > > > during the last steps of converting the reftable codebase to become a > > standalone library I noticed that the new -Wsign-compare warnings > > created a bit of a problem due to the `DISABLE_SIGN_COMPARE_WARNINGS` > > macro that we started using. As a consequence I wasn't able to easily > > drop "git-compat-util.h" anymore. This patch series is thus addresses > > the issue by fixing all sign comparison warnings in the reftable > > library. > > > > Thanks! > > > > Most of the patches were straightforward and look good. I left only nits > on one commit, which doesn't warrant a re-roll. Thanks for your review! I'll send v2 in a bit. Patrick
