On Fri, Jan 17, 2025 at 04:42:01PM -0800, Junio C Hamano wrote: > * jk/pack-header-parse-alignment-fix (2025-01-17) 3 commits > - index-pack, unpack-objects: use skip_prefix to avoid magic number > - parse_pack_header_option(): avoid unaligned memory writes > - packfile: factor out --pack_header argument parsing > > It was possible for "git unpack-objects" and "git index-pack" to > make an unaligned access, which has been corrected. > > Will merge to 'next'. > source: <20250117125207.GB2356599@xxxxxxxxxxxxxxxxxxxxxxx> I was planning to re-roll this with your sparse fix included, and adding another patch to do get_be32() on the reading side. So maybe hold off for a moment. (I'd also be interested in any comments on the "maybe we should just align these buffers" approach; I'm undecided on it). -Peff
