On Fri, Jan 17, 2025 at 01:29:22PM +0100, Seyi Kuforiji wrote: > Hello, > > This small patch series transitions the existing unit test files to the > Clar testing framework. This change is part of our ongoing effort to > standardize our testing approach and enhance maintainability. > > changes in v3: > - Some small fixes were made to the commit messages Thanks, the series looks good to me now. > Range-diff against v2: > 1: 00bb4d2880 ! 1: f9e163a181 t/unit-tests: handle dashes in test suite filenames > @@ Metadata > ## Commit message ## > t/unit-tests: handle dashes in test suite filenames > > - The script is designed to extract function signatures that match a > - specific pattern derived from the unit test file's name. > - `generate-clar-decls.sh` does not pick up dashes in filenames, which > - prevents the scripts from being run. > + "generate-clar-decls.sh" script is designed to extract function > + signatures that match a specific pattern derived from the unit test > + file's name. The script does not know to massage file names with dashes, > + which will make it search for functions that look like, for example, > + `test_mem-pool_*`. Having dashes in function names is not allowed > + though, so these patterns won't ever match a legal function name. > > Adapt script to translate dashes (`-`) in test suite filenames to > underscores (`_`) to correctly extract the function signatures and run > -: ---------- > 2: f46438f53e t/unit-tests: convert mem-pool test to use clar test framework > -: ---------- > 3: f5cabebd3a t/unit-tests: adapt priority queue test to use clar test framework > -: ---------- > 4: 5323873612 t/unit-tests: convert reftable tree test to use clar test framework The range-diff is still not correct :P Now it seems like you only passed the first commit of your v2 to it, instead of the tip of the v2 branch. Patrick
