Re: [PATCH 2/4] version: refactor get_uname_info()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Junio

On Mon, Jan 6, 2025 at 9:34 PM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> Usman Akinyemi <usmanakinyemi202@xxxxxxxxx> writes:
>
> > Some code from "builtin/bugreport.c" uses uname(2) to get system
> > information.
> >
> > Let's refactor this code into a new get_uname_info() function, so
> > that we can reuse it in a following commit.
>
> This does two things: refactor and enhancement.  Shouldn't it do
> pure refactoring in a single patch, with a follow-up patch that
> extends it to allow the caller to hide the system details?
>
Thanks for this, I will split the commit into two patches in the next iteration.





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux