Re: [PATCH] t7407: use test_grep

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 7, 2025 at 2:42 PM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> "Kristoffer Haugsbakk" <kristofferhaugsbakk@xxxxxxxxxxxx> writes:
>
> > On Tue, Jan 7, 2025, at 08:18, Jeff King wrote:
> >> get rid of them.
> >>
> >> (It is also curious to grep in the expected file in the first place, but
> >> that is because we are auto-generating the expectation from a Git
> >> command. So this is double-checking it did what we wanted).
> >
> > Missing “that”? s/it did/that it did/
>
> It is colloquially correct, isn't it?
>
>

Reads fine to me.


-- 
D. Ben Knoble





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux