On Sun, Jan 5, 2025 at 4:39 AM Rhythm Narula <rhythm.narula26@xxxxxxxxx> wrote:
> 1. Avoid suppressing git’s exit code in test scripts
> a. diff --git a/t/t5801-remote-helpers.sh b/t/t5801-remote-helpers.sh
> @@ -271,7 +271,7 @@ test_expect_success 'push update refs failure' '
> clean_mark () {
> cut -f 2 -d ' ' "$1" |
> - git cat-file --batch-check |
> + git cat-file --batch-check >actual &&
> grep commit |
> sort >$(basename "$1")
> }
At a quick glance, I'd say that this change is incomplete and won't
work as you expect.
> 2. Modernize a test script
> Is there anyone working on t/t5801-remote-helpers.sh? Can I take this up?
No need to ask before working on something in Git. You're free to pick
any modernization. A good way to check if anyone is touching this
particular script is to search the mail archive[*] for recent mentions
of "t5801".
[*]: https://lore.kernel.org/git/
