Junio C Hamano <gitster@xxxxxxxxx> writes: > Christian Couder <chriscool@xxxxxxxxxxxxx> writes: > >> If refs were ever packed in the middle of bisection, the bisect >> refs were not removed from the "packed-refs" file. >> >> This patch fixes this problem by using "git update-ref -d $ref $hash" >> in "bisect_clean_state". >> >> Signed-off-by: Christian Couder <chriscool@xxxxxxxxxxxxx> > > Thanks. Just a few nits. > > On top of your patch... > > - You forgot to remove one "removal of filesystem refs"; Ooops. 'test -d "$GIT_DIR/refs/bisect"' is used as a signal that we are bisecting for the rest of the code, so we cannot lose that rm -fr there. I think a longer term clean-up would be not to treat "bisect" as a reserved branch name but use detached HEAD while bisecting. But that is a larger topic. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
