Hi Junio,
I think I undersand your first mail correct, that this is only a code
quality change and not a bug in the code. And so it isn't critical for
git 2.48.
In the future I will send some more commits for warings from msvc in
git. MSVC print more the 1000 warings.
Best regards,
Sören Krecker
Am 23.12.24 um 17:52 schrieb Junio C Hamano:
Junio C Hamano <gitster@xxxxxxxxx> writes:
Sören Krecker <soekkle@xxxxxxxxxx> writes:
A smale series of patches to fix some typemissmatch warings from msvc 14.30.
Most of the missmatches a 64 to 32 bit conversion on a 64 bit Windows platform.
Thanks for the patches.
I'll welcome other people to take a look, if they are inclined, but
it is not something I'd want to look at during a pre-release freeze.
Nobody sane would be running "git add -p" on a patch that exceeds
2GB, for example, so the only practical thing they fix are compiler
warnings. They are worth fixing eventually, but not all that
urgent.
Thanks, again.
Oops, sorry, this didn't come out quite right. I didn't mean to say
that this contribution is unwelcome. I'll get to it eventually
(like, after the upcoming release), but please do not expect them to
be merged before the upcoming release.
