On Wed, Nov 14, 2007 at 10:04:25AM +0100, Wincent Colaiuta wrote: >>> +A `filter` attribute can be set to a string value which names a >>> filter driver specified in the configuration. >> >> Will we get the canned "which vs that" discussion on this change? > > Perhaps. Neither would be incorrect, although technically "that" is a > tighter match. Really? I would think "which" works better, in that it is not restrictive. I.e., "The filter attribute is set to a string. This string, btw, names a filter driver" (which) rather than "The filter attribute is set to a string, and from the set of strings, it is set to the particular string that names a filter driver" (that). But in the non-restrictive case, it should be in a parenthetical phrase: A `filter` attribute can be set to a string value, which names a filter driver specified in the configuration. I think either is readable, though. :) -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html