On Fri, Dec 20, 2024 at 01:22:48PM +0100, Patrick Steinhardt wrote: > In preceding commits we fixed that build info set via e.g. `make > GIT_VERSION=foo` didn't get propagated to GIT-VERSION-GEN. Similarly > though, setting build info via "config.mak" does not work anymore either > because the variables are only declared as Makefile variables and thus > aren't accessible by the script. > > Fix the issue by exporting those variables via "shared.mak". This also > allows us to deduplicate the export of GIT_USER_AGENT. This looks good. It fixes the issue, and I am happy that: > asciidoctor-extensions.rb: asciidoctor-extensions.rb.in FORCE > - $(QUIET_GEN)GIT_USER_AGENT="$(GIT_USER_AGENT)" $(SHELL_PATH) ../GIT-VERSION-GEN "$(shell pwd)/.." $< $@ > + $(QUIET_GEN)$(SHELL_PATH) ../GIT-VERSION-GEN "$(shell pwd)/.." $< $@ ...these spots get even simpler. -Peff
