On Wed, Nov 14, 2007 at 02:01:14AM +0000, Johannes Schindelin wrote: > Since when can refnames contain spaces? In my copy of git, bad_ref_char() > in refs.c returns 1 if ch <= ' '. It's the first error path, even. Oops, I'm clearly an idiot. I explicitly looked at bad_ref_char before writing the original message, and somehow read that as strictly less than. So the parsing problem goes away, and I think using the sort order as a hint takes away the potential performance problem (I don't even know if it was a problem -- there may be other O(n^2) behavior). I will take a look at the tests Alex has been working on, maybe add a few to it, and submit a cleaned-up series. -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
