Christian Couder <christian.couder@xxxxxxxxx> writes: > We often have to split strings at some specified terminator character. > The strbuf_split*() functions, that we can use for this purpose, > return substrings that include the terminator character, so we often > need to remove that character. > > When it is a whitespace, newline or directory separator, the > terminator character can easily be removed using an existing triming Nit: s/triming/trimming > function like strbuf_rtrim(), strbuf_trim_trailing_newline() or > strbuf_trim_trailing_dir_sep(). There is no function to remove that > character when it's not one of those characters though. > > Let's introduce a new strbuf_trim_trailing_ch() function that can be > used to remove any trailing character, and let's refactor existing code > that manually removed trailing characters using this new function. > > We are also going to use this new function in a following commit. > > Signed-off-by: Christian Couder <chriscool@xxxxxxxxxxxxx> > --- > strbuf.c | 7 +++++++ > strbuf.h | 3 +++ > trace2/tr2_cfg.c | 10 ++-------- > 3 files changed, 12 insertions(+), 8 deletions(-) > Shouldn't this patch also add unit tests? We already have some in 't/unit-tests/t-strbuf.c'. This applies to the previous patch too. [snip]
Attachment:
signature.asc
Description: PGP signature
