Re: git rebase --continue error message is misleading

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Björn

Thanks for reporting this

On 09/12/2024 13:02, Björn Lindqvist wrote:
$ LANG=C git rebase --continue
hint: Waiting for your editor to close the file... error: cannot run
vi: No such file or directory
error: unable to start editor 'vi'
Please supply the message using either -m or -F option.

This line comes from "git commit" whenever launch_editor() fails. I wonder if we'd be better to recommend that the user sets up a working editor instead. The message is certainly unhelpful when we run "git commit" from "git cherry-pick/merge/rebase/revert" where we want to seed the message that the user edits.

error: could not commit staged changes.
$ git rebase --continue -m "done"
...
$ git rebase --continue -F "done ffs"
...

It should say: Please commit the staged changes using git commit -m
"commit message"

I don't think that is a good idea when "git commit" is being run from "git rebase". In that case we want to preserve the original message and authorship and using '-F' or '-m' would not do that.

Best Wishes

Phillip





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux