El 14/11/2007, a las 21:04, Junio C Hamano escribió:
Wincent Colaiuta <win@xxxxxxxxxxx> writes:
El 14/11/2007, a las 18:19, Johannes Schindelin escribió:
Besides, is it really necessary to be as explicit as you word it?
IOW is
this patch needed?
I was basically just trying to help new people from making the same
mistake that I did; ie. not knowing if there was an official limit,
looking at the maximum line length in a file, making sure my patch
didn't exceed that length (and re-wrapping to avoid exceeding it),
and
then getting reprimanded for gratuitous re-wrapping.
Sorry about that "reprimanded" part. I should have been more
careful -- I did not really mean it that way. It was more like
"it would have been nicer ... so please try to next time".
Don't worry about it, Junio. I've been subscribed to the list for
several months now, so I'm already aware of the perfectionism inherent
in the process; I didn't take anything personally, and much less
coming from you who is always diplomatic. I just thought, "this is
good advice that Junio has posted to the list, I found it helpful, so
I think it should go in the style doc".
And I'm no stranger to Johannes' scything sarcasm either, it's his
personal style; luckily, along with the sarcasm he makes so many high-
quality contributions to the community as well.
I agree that "80 columns" sits better in that new "Line
wrapping" section. I wonder if "tabs are 8 spaces wide" also
belong there.
You're probably right; I understand that the 8-wide tabs convention
holds in shell and perl scripts too, not just in C source.
Cheers,
Wincent
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
