On Thu, Dec 05, 2024 at 09:21:32AM +0100, Bence Ferdinandy wrote: > On Wed Dec 04, 2024 at 18:19, Justin Tobler <jltobler@xxxxxxxxx> wrote: > > On 24/12/04 02:08PM, Bence Ferdinandy wrote: > > There does appear to be other instances where the the advice turn off > > instructions are open-coded and thus retain the prior format. This does > > result in some inconsistency, which may not be a big deal, but maybe it > > would make sense to also adjust those sites as part of this series as > > also. Otherwise the changes in this patch look correct. > > Fair point. Grepping the .c files yielded three more instances, I'll change > those as well. Yeah. Overall I think it is fine to do an iterative transition to the new interface. `git config set` is not going to be the only instance that needs changes, but I very much assume that we will have suggestions and warnings all over the place that may recommend other modes of the command like the equivalent of `git config get`. But these don't have to all happen in the same commit, or even the same patch series, from my point of view. Thanks for working on this! Patrick
