Jeff King <peff@xxxxxxxx> writes: >> I am not all that convinced that sprinkling setup_diff_pager() call >> all over the place is a good idea from longer-term maintainability's >> sake to begin with, by the way. What problem are we really solving? >> Folks who run "git diff --no-such-option" see "behaviour inconsistency"? >> All I see is "error: invalid option: --invalid" followed by a help message, >> which is quite expected. > > I think it is just about not starting the pager when there is no useful > output produced. Depending on your pager config, it is a little nicer if > we avoid it for a one-liner error. E.g., I do not use "-F", so "git diff > foo bar" drops me into the pager with a single error line. OOok...
