Thank you, Patrick. Your comments make perfect sense to me, and I will revise them accordingly to v8. On Mon, Nov 25, 2024 at 4:51 AM Patrick Steinhardt <ps@xxxxxx> wrote: > > On Mon, Nov 25, 2024 at 12:36:12AM -0500, Eric Ju wrote: > > diff --git a/connect.h b/connect.h > > index 1645126c17..8b56a68b62 100644 > > --- a/connect.h > > +++ b/connect.h > > @@ -1,6 +1,7 @@ > > #ifndef CONNECT_H > > #define CONNECT_H > > > > +#include "string-list.h" > > #include "protocol.h" > > > > #define CONNECT_VERBOSE (1u << 0) > > Instead of including this header, you can add a forward declaration of > `struct string_list`. This is mostly done to keep compilation times at > bay by not including too many headers. > > > @@ -30,4 +31,11 @@ void check_stateless_delimiter(int stateless_rpc, > > struct packet_reader *reader, > > const char *error); > > > > +/** > > + * write_command_and_capabilities writes a command along with the requested > > Nit: we don't typically use Go-style comments where the comment starts > with the name of what's being documented. > > Patrick
