Patrick Steinhardt <ps@xxxxxx> writes: > On Tue, Dec 03, 2024 at 03:48:10PM +0900, Junio C Hamano wrote: >> * kn/midx-wo-the-repository (2024-11-28) 10 commits >> - midx: inline the `MIDX_MIN_SIZE` definition >> - midx: pass down `hash_algo` to functions using global variables >> - midx: pass `repository` to `load_multi_pack_index` >> - midx: cleanup internal usage of `the_repository` and `the_hash_algo` >> - midx-write: pass down repository to `write_midx_file[_only]` >> - write-midx: add repository field to `write_midx_context` >> - midx-write: use `revs->repo` inside `read_refs_snapshot` >> - midx-write: pass down repository to static functions >> - Merge branch 'kn/pass-repo-to-builtin-sub-sub-commands' into kn/midx-wo-the-repository >> - Merge branch 'kn/the-repository' into kn/midx-wo-the-repository >> (this branch uses kn/pass-repo-to-builtin-sub-sub-commands and kn/the-repository.) >> >> Yet another "pass the repository through the callchain" topic. >> >> Will merge to 'next'? >> source: <20241127-374-refactor-midx-c-and-midx-write-c-to-not-depend-on-global-state-v3-0-c5a99f85009b@xxxxxxxxx> > > This series looks good to me. > Thanks Patrick. [snip] >> * kn/the-repository (2024-11-27) 10 commits >> - packfile.c: remove unnecessary prepare_packed_git() call >> - midx: add repository to `multi_pack_index` struct >> - config: make `packed_git_(limit|window_size)` non-global variables >> - config: make `delta_base_cache_limit` a non-global variable >> - packfile: pass down repository to `for_each_packed_object` >> - packfile: pass down repository to `has_object[_kept]_pack` >> - packfile: pass down repository to `odb_pack_name` >> - packfile: pass `repository` to static function in the file >> - packfile: use `repository` from `packed_git` directly >> - packfile: add repository to struct `packed_git` >> (this branch is used by kn/midx-wo-the-repository.) >> >> Various implicit uses of 'the_repoository' in the packfile code >> have been eliminated. >> >> Will merge to 'next'? >> source: <cover.1732618495.git.karthik.188@xxxxxxxxx> > > I think there were two nits that Karthik has addressed but not yet sent > out. May make sense to wait for that final reroll before merging it > down. > I was holding out on re-rolling since they were minor, but I think it is best addressed, I've pushed a new version with the fixes now, we should be good to merge it to 'next'. Thanks both.
Attachment:
signature.asc
Description: PGP signature
