"Elijah Newren via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > From: Elijah Newren <newren@xxxxxxxxx> > > Instead of just disallowing '.' and '..', make use of verify_path() to > ensure that fast-import will disallow anything we wouldn't allow into > the index, such as anything under .git/, .gitmodules as a symlink, or > a dos drive prefix on Windows. > > Since a few fast-export and fast-import tests that tried to stress-test > the correct handling of quoting relied on filenames that fail > is_valid_win32_path(), such as spaces or periods at the end of filenames > or backslashes within the filename, turn off core.protectNTFS for those > tests to ensure they keep passing. > > Signed-off-by: Elijah Newren <newren@xxxxxxxxx> > --- > Disallow verify_path() failures from fast-import > > Since en/fast-import-path-sanitize has already made it to next, this > commit is based on that. (See > https://lore.kernel.org/git/pull.1831.v2.git.1732561248717.gitgitgadget@xxxxxxxxx/ > for discussion of that series.) > > Changes relative to that commit: this fixes up the error message as > suggested by Kristoffer, and makes the checks more encompassing as > suggested by Patrick and Peff -- in particular, using verify_path() as > suggested by Peff. > > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1832%2Fnewren%2Fdisallow-verify-path-fast-import-v1 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1832/newren/disallow-verify-path-fast-import-v1 > Pull-Request: https://github.com/gitgitgadget/git/pull/1832 Thanks, all. Looking good to me. Will queue.
