On Tue, Nov 26, 2024, at 12:24, Phillip Wood wrote: > On 26/11/2024 01:11, Junio C Hamano wrote: >> kristofferhaugsbakk@xxxxxxxxxxxx writes: >> >>> From: Kristoffer Haugsbakk <code@xxxxxxxxxxxxxxx> >>> >>> Fix three places where the comment char/string is hardcoded (#) in the >>> todo list. >>> >>> § Changes in v4 >>> >>> • Use `test_grep` >>> • Fix commit message (`) >>> • Don’t need to cat(1) >>> • Also use `-n4` in case `-4` is not widely supported >> >> All changes make sense. Will queue. > > This version looks good to me too, thanks for working on it Kristoffer Thanks for the reviews and for finishing the last test coverage in this series (fixup -c/-C). I was not familiar with that code as a user so I didn’t know what was expected. Cheers -- Kristoffer