Re: [PATCH v9 01/10] packfile: add repository to struct `packed_git`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Kristoffer Haugsbakk" <kristofferhaugsbakk@xxxxxxxxxxxx> writes:

> On Tue, Nov 26, 2024, at 11:57, Karthik Nayak wrote:
>> We do need to consider that a pack file could be part of the alternates
>> of a repository, but considering that we only have one repository struct
>> and also that we currently anyways use 'the_repository'. We should be
>> OK with this change.
>
> The “but considering” needs for a conclusion to come in the same
> sentence.  But it seems that the conclusion has been put off to the next
> sentence: “We should be OK with this change”.  That doesn’t read right
> to me.

Hmm, yeah, perhaps a comma right after the 'the_repository' instead of a
period would make it better.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux