Christian Couder <christian.couder@xxxxxxxxx> writes: > On Mon, Nov 25, 2024 at 3:56 PM Karthik Nayak <karthik.188@xxxxxxxxx> wrote: >> >> In 9b1cb5070f (builtin: add a repository parameter for builtin >> functions, 2024-09-13) the repository was passed down to all builtin >> commands. This allowed the repository to be passed down to lower layers >> without depending on the global `the_repository` variable. >> >> Continue this work by also passing down the repository parameter from >> the command to sub-commands. This will help pass down the repository to >> other subsystems and cleanup usage of global variables like >> 'the_repository' and 'the_hash_algo'. >> >> Signed-off-by: Karthik Nayak <karthik.188@xxxxxxxxx> > > Yeah, this is definitely needed to cleanup usage of global variables, > and looks well done to me. Ack. > Thanks for the review.
Attachment:
signature.asc
Description: PGP signature
