Hi, On Mon, Nov 25, 2024 at 8:38 AM Patrick Steinhardt <ps@xxxxxx> wrote: > > Hi, > > this is the second version of my patch series that refactors the Do you mean that despite the "v3" mark, it's only the second version because "v2" was just rebasing "v1" on top of a better base? > reftable backend to reuse iterators when reading random references. This > removes the overhead of having to recreate the iterator on every read > and thus leads to better performance and less allocation churn. > > Changes in v3: > > - Adapt some comments to refer to the "backend" instead of to the > "stack". > - Fix indentation of a statement while at it. > - Explain why callsites don't want to reload the stack. > - Optimize `prepare_transaction_update()` by not using `backend_for()` > twice, but instead reload the stack manually. > - Split out the change that adds `reftable_stack_hash_id()` into a > separate commit. > - Link to v2: https://lore.kernel.org/r/cover.1730792627.git.ps@xxxxxx Thanks!