"Bence Ferdinandy" <bence@xxxxxxxxxxxxxx> writes: > On Fri Nov 22, 2024 at 11:37, karthik nayak <karthik.188@xxxxxxxxx> wrote: >> Bence Ferdinandy <bence@xxxxxxxxxxxxxx> writes: >> >> [snip] >> >>> diff --git a/refs/reftable-backend.c b/refs/reftable-backend.c >>> index 38eb14d591..1809e3426a 100644 >>> --- a/refs/reftable-backend.c >>> +++ b/refs/reftable-backend.c >>> @@ -830,10 +830,12 @@ static int reftable_be_read_symbolic_ref(struct ref_store *ref_store, >>> return ret; >>> >>> ret = reftable_stack_read_ref(stack, refname, &ref); >>> - if (ret == 0 && ref.value_type == REFTABLE_REF_SYMREF) >>> + if (ret) >>> + ret = -1; >>> + else if (ref.value_type == REFTABLE_REF_SYMREF) >>> strbuf_addstr(referent, ref.value.symref); >>> - else >>> - ret = -1; >>> + else >>> + ret = NOT_A_SYMREF; >>> >> >> I was building my series on top of this, and noticed whitespace issues >> here. A simple way to check your series is to run: >> >> $ git log --check --pretty=format:"---% h% s" > > I ran this on v15 and it didn't produce any output. Did you already post v15? I only see v14 > I read what --check is in > the manpages, although the format is a bit cryptic for me. What does that do > exactly? > It ensures that commits don't have conflict markers and that there are no trailing whitespaces and spaces followed by tabs by default. Also this is included in the CI checks (see ci/check-whitespace.sh), so if you use either GitLab or GitHub you should see these shown as errors on the CI. You'll have to raise a MR/PR to trigger the CI I believe. On a sidenote, do you think we should modify the manpage? I found it comprehensible, but would be nice to clarify anything cryptic. > Anyhow if there was no output for v15 I should be fine, right? > At the least you should see `git log`'s output, but if there are issues they should be shown inline. So when you say 'no output' do you mean you see absolutely no output? >> >>> reftable_ref_record_release(&ref); >>> return ret; >>> -- >>> 2.47.0.298.g52a96ec17b > > > > > -- > bence.ferdinandy.com
Attachment:
signature.asc
Description: PGP signature
