Re: [PATCH v2 05/10] midx-write: pass down repository to `write_midx_file[_only]`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2 05/10] midx-write: pass down repository to `write_midx_file[_only]`
From: Taylor Blau <me@xxxxxxxxxxxx>
Date: Wed, 20 Nov 2024 15:11:57 -0500
Cc: git@xxxxxxxxxxxxxxx, ps@xxxxxx, shejialuo@xxxxxxxxx
In-reply-to: <20241119-374-refactor-midx-c-and-midx-write-c-to-not-depend-on-global-state-v2-5-e2f607174efc@gmail.com>
References: <20241119-374-refactor-midx-c-and-midx-write-c-to-not-depend-on-global-state-v2-0-e2f607174efc@gmail.com> <20241119-374-refactor-midx-c-and-midx-write-c-to-not-depend-on-global-state-v2-5-e2f607174efc@gmail.com>

On Tue, Nov 19, 2024 at 04:36:44PM +0100, Karthik Nayak wrote:
> With this, all usage of global variables in `midx-write.c` is removed,
> hence, remove the `USE_THE_REPOSITORY_VARIABLE` guard from the file.

Very nicely done :-). Thanks for cleaning these up!

Thanks,
Taylor

References:
- [PATCH v2 00/10] Change midx.c and midx-write.c to not use global variables
  - From: Karthik Nayak
- [PATCH v2 05/10] midx-write: pass down repository to `write_midx_file[_only]`
  - From: Karthik Nayak

Prev by Date: Re: How do you undo an add
Next by Date: Re: [PATCH v2 09/10] midx: pass down `hash_algo` to `get_split_midx_filename_ext`
Previous by thread: [PATCH v2 05/10] midx-write: pass down repository to `write_midx_file[_only]`
Next by thread: [PATCH v2 04/10] write-midx: add repository field to `write_midx_context`
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux