On Tue, Nov 19, 2024 at 12:10:15PM -0800, Jonathan Tan wrote: > Thanks, Peff, for the catch. Here's an updated patch, with an updated > commit message. This looks good to me, thanks. > Range-diff against v1: > [...] > @@ Commit message > test here any more.) > > [1] https://lore.kernel.org/git/20241114005652.GC1140565@xxxxxxxxxxxxxxxxxxxxxxx/ > + [2] https://lore.kernel.org/git/20241119185345.GB15723@xxxxxxxxxxxxxxxxxxxxxxx/ > > Signed-off-by: Jonathan Tan <jonathantanmy@xxxxxxxxxx> > --- > This is on jt/repack-local-promisor. > > - Looking into it further, I think that we also need to require no > - packfile name to be given (so that we are writing the file to the > - repository). Therefore, I've added that requirement both in the code and > - in the documentation. > - > - I've tried to summarize our conversation in the commit message - if you > - notice anything missing or incorrect, feel free to let me know. > + Thanks, Peff, for the catch. Here's an updated patch, with an updated > + commit message. Heh, I guess you stick your notes directly into the commit message. ;) I do that sometimes, too. A long time ago I had a patch that would let you write "---" in the commit message editor and then auto-convert that into actual notes. Probably not that big a deal, though. -Peff
