Re: [PATCH v2] fast-import: avoid making replace refs point to themselves

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2] fast-import: avoid making replace refs point to themselves
From: Junio C Hamano <gitster@xxxxxxxxx>
Date: Tue, 19 Nov 2024 09:44:10 +0900
Cc: git@xxxxxxxxxxxxxxx, Elijah Newren <newren@xxxxxxxxx>
Feedback-id: if26b431b:Fastmail
In-reply-to: <pull.1824.v2.git.1731968389590.gitgitgadget@gmail.com> (Elijah Newren via GitGitGadget's message of "Mon, 18 Nov 2024 22:19:49 +0000")
References: <pull.1824.git.1731610074707.gitgitgadget@gmail.com> <pull.1824.v2.git.1731968389590.gitgitgadget@gmail.com>
User-agent: Gnus/5.13 (Gnus v5.13)

"Elijah Newren via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:

> +		grep "Dropping.*since it would point to itself" msgs &&
> +		git show-ref >refs &&
> +		! grep refs/replace refs

"test_grep !" may make a failure case easier to diagnose.

Other than that, looking good.

Thanks, will queue.

References:
- [PATCH] fast-import: avoid making replace refs point to themselves
  - From: Elijah Newren via GitGitGadget
- [PATCH v2] fast-import: avoid making replace refs point to themselves
  - From: Elijah Newren via GitGitGadget

Prev by Date: Re: [PATCH v2] diff: update conflict handling for whitespace to issue a warning
Next by Date: Re: [PATCH v13 2/9] refs: standardize output of refs_read_symbolic_ref
Previous by thread: [PATCH v2] fast-import: avoid making replace refs point to themselves
Next by thread: [PATCH 0/1] Restore the ability to clone repositories owned by another user
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux