On 2024-11-18 at 07:45:03, Patrick Steinhardt wrote: > Both of the patches look obviously good to me. I was a bit surprised > that this is required in the first place as I thought we were passing > `-std=gnu99` to our compilers, but that is not the case with our current > Makefile. So I must have been misremembering. We can't do that because FreeBSD's system headers require C11 and won't work with `-std=gnu99`, in addition to the general unportability of that construct as mentioned by Peff. There's a comment to that effect in `config.mak.dev`. I'm pleased you found the patches acceptable, though. -- brian m. carlson (they/them or he/him) Toronto, Ontario, CA
Attachment:
signature.asc
Description: PGP signature
