karthik nayak <karthik.188@xxxxxxxxx> writes: > Patrick Steinhardt <ps@xxxxxx> writes: > > [snip] > >> + >> +int tmpfile_close(struct reftable_tmpfile *t) >> +{ >> + struct tempfile *tempfile = t->priv; >> + int ret = close_tempfile_gently(tempfile); >> + t->fd = -1; > > Nit: below we do `*t = REFTABLE_TMPFILE_INIT` should we keep things > consistent and do the same here? > My bad, we want this to still hold onto `t->priv` which is cleared when we call tmpfile_delete(). So all good here.
Attachment:
signature.asc
Description: PGP signature