On Sun, Nov 17, 2024 at 10:52:40AM +0100, René Scharfe wrote:
> > -#define EMPTY_BLOB_SHA256_BIN_LITERAL \
> > - "\x47\x3a\x0f\x4c\x3b\xe8\xa9\x36\x81\xa2" \
> > - "\x67\xe3\xb1\xe9\xa7\xdc\xda\x11\x85\x43" \
> > - "\x6f\xe1\x41\xf7\x74\x91\x20\xa3\x03\x72" \
> > - "\x18\x13"
> > +#define EMPTY_TREE_SHA1_BIN_LITERAL { \
> > + 0x4b, 0x82, 0x5d, 0xc6, 0x42, 0xcb, 0x6e, 0xb9, 0xa0, 0x60, \
> > + 0xe5, 0x4b, 0xf8, 0xd6, 0x92, 0x88, 0xfb, 0xee, 0x49, 0x04 \
>
> The added space at the beginning looks seems unintended.
That was from the original, which had a tab followed by a space (maybe
to line up with the "E" in "EMPTY"?). I did s/"// and s/\\x\(..\)/0x\1, /
which left it.
> The two spaces before the backslash look odd. One space, one tab or
> lining up the backslashes with spaces would look better.
This one is my fault, though. My regex left an extra comma at the end,
which I somehow managed to bungle removing. ;)
> Patch 5 does away with those spaces, thankfully. :)
Yep. Looks like there might be some whitespace oddities left over,
though, so I'll fix this on re-roll.
Thanks.
-Peff
