Hi,
Dscho has reported in [1] that the CMake build instructions for clar do
not work well on Windows/MSVC because we execute the shell scripts
directly instead of using the discovered `SH_EXE`. This small patch
series fixes the issue.
Changes in v2:
- Wrap overly long lines in the CMake build instructions.
- Add the VERBATIM option.
Changes in v3:
- Fix missing word.
Link to v1: https://lore.kernel.org/r/20241108-pks-clar-build-improvements-v1-0-25c1fe65ce37@xxxxxx
Link to v2: https://lore.kernel.org/r/20241111-pks-clar-build-improvements-v2-0-d4794d8d1b30@xxxxxx
Thanks!
Patrick
[1]: <3b2cb360-297a-915c-ae27-c45f38fa49b9@xxxxxx>
To: git@xxxxxxxxxxxxxxx
Cc: Johannes Schindelin <Johannes.Schindelin@xxxxxx>
Cc: Phillip Wood <phillip.wood123@xxxxxxxxx>
Cc: Junio C Hamano <gitster@xxxxxxxxx>
Patrick Steinhardt (4):
t/unit-tests: convert "clar-generate.awk" into a shell script
cmake: use SH_EXE to execute clar scripts
cmake: use verbatim arguments when invoking clar commands
Makefile: let clar header targets depend on their scripts
Makefile | 6 ++--
contrib/buildsystems/CMakeLists.txt | 16 ++++++---
t/unit-tests/clar-generate.awk | 50 ----------------------------
t/unit-tests/generate-clar-suites.sh | 63 ++++++++++++++++++++++++++++++++++++
4 files changed, 78 insertions(+), 57 deletions(-)
Range-diff versus v2:
1: 90d2402c5a ! 1: dc713c236b t/unit-tests: convert "clar-generate.awk" into a shell script
@@ Commit message
may otherwise be a problem with build systems on platforms that use a
different shell.
- While at it, wrap the overly lines in the CMake build instructions.
+ While at it, wrap the overly long lines in the CMake build instructions.
Signed-off-by: Patrick Steinhardt <ps@xxxxxx>
2: cf298664d8 = 2: 19d292cc5c cmake: use SH_EXE to execute clar scripts
3: ff557f8985 = 3: 52f5090a76 cmake: use verbatim arguments when invoking clar commands
4: c634e2a6d4 = 4: 35117454d4 Makefile: let clar header targets depend on their scripts
---
base-commit: facbe4f633e4ad31e641f64617bc88074c659959
change-id: 20241108-pks-clar-build-improvements-1c3962a9a79f
