On Wed, Nov 13, 2024 at 01:21:52AM -0800, David Aguilar wrote:
> On Mon, Nov 11, 2024 at 11:36:34AM +0100, Patrick Steinhardt wrote:
> > On Sat, Nov 09, 2024 at 04:58:56AM -0800, David Aguilar wrote:
> (3) Not all of the same files seems to be getting installed.
>
> I don't see bin/gitk or bin/git-cvsserver when building with Meson.
gitk is intentionally committed. git-cvsserver is fixed now.
> The share/git-core/templates/ directory is missing completely.
Fixed.
> git-gui and its related files are missing. Perhaps this is
> intentional/todo at this stage and hasn't been added yet.
Yup, this is intentionally omitted for now.
> Meson installs bin/git-http-backend (symlinked to libexec)
> but in the original Makefile this file only exists in libexec/.
Huh, true. On my system (NixOS) it's also installed in 'bin/', but when
using the Makefile it indeed only ends up in 'libexec/'. Fixed now.
> The contents of libexec/git-core/ seems to be missing dozens of
> files compared to the Makefile build.
This is intentional, as I'm dropping the dashed builitins. Git does not
need these nowadays and resolves them internally anyway.
> share/perl5/ has a bunch of extra git-{cvsserver,send-email,svn,...}
> scripts so perhaps this is where some of those files went?
> The Makefile places these files in the libexec/ area instead
> of in the share/perl5/ area.
Fixed.
> The Makefile does not install share/gitweb/static/js/.
> Instead, it seems to mash everything together into a single
> share/gitweb/static/gitweb.js file which Meson does not install.
> Meson installs separate files in the share/gitweb/static/js/ area.
> Was that intentional, or is that just another todo?
No, this was unintentional, fixed now. What is missing in this context
is wiring up jsmin and cssmin, but I'll leave that as a todo for now.
Will send a new version later today with these fixes.
Patrick
