On Thu, Nov 07, 2024 at 04:33:56PM -0500, Taylor Blau wrote:
> > # Compute and append pack trailer to "$1"
> > pack_trailer () {
> > test-tool $(test_oid algo) -b <"$1" >trailer.tmp &&
> > cat trailer.tmp >>"$1" &&
> > rm -f trailer.tmp
> > }
>
> Nice find. I think that it may be worth writing this as:
>
> case "$(test_oid algo)" in
> sha1)
> test-tool sha1 -b <"$1" >trailer.tmp
> ;;
> sha256)
> test-tool sha256 -b <"$1" >trailer.tmp
> ;;
> *)
> echo >&2 "unknown algorithm: $(test_oid algo)"
> exit 1
> ;;
> esac
If it were "test-tool hash --algo=$(test_oid algo)", then presumably
test-tool would naturally do the same switch and error message
internally.
-Peff
