On Wed, Nov 06, 2024 at 10:59:08AM +0000, Phillip Wood wrote: > Hi Johannes > > On 05/11/2024 19:55, Johannes Schindelin wrote: > > Hi Patrick, > > > > On Mon, 21 Oct 2024, Patrick Steinhardt wrote: > > > > > The auto-generated headers used by clar are written at configure time > > > and thus do not get regenerated automatically. Refactor the build > > > recipes such that we use custom commands instead, which also has the > > > benefit that we can reuse the same infrastructure as our Makefile. > > > > For the record: I did not use a shell script to generate the header for a > > specific reason: Unix shell scripts are not native to Windows. Therefore > > they cannot in general be run on Windows, however that was precisely the > > idea for the CMake definition: to be run on a vanilla Windows with Visual > > Studio installed. > > > > Sadly, even Git's CI definition sets things up in a way that Git for > > Windows' Bash can be used in the CMake definition, but in the intended use > > case (opening a checkout of git/git in Visual Studio without any further > > tools required) won't have a usable Bash. > > > > Therefore I am unsure whether this patch is desirable. > > CMakeLists.txt tries to find sh.exe from git-for-windows and errors out if > it cannot be found. It then uses that shell to run a number of scripts. > Perhaps we should do the same in this patch? It would certainly be a > worthwhile improvement to regenerate this file at build time if the source > has changed. Yeah, I think this solution makes most sense. I'll send a patch in a bit to address this. Thanks, both of you! Patrick
