On Thu, Nov 07, 2024 at 07:10:11PM -0600, Justin Tobler wrote: > On 24/10/23 11:56AM, Patrick Steinhardt wrote: > > diff --git a/refs/reftable-backend.c b/refs/reftable-backend.c > > index 3c6107c7ce5..7d86d920970 100644 > > --- a/refs/reftable-backend.c > > +++ b/refs/reftable-backend.c > > diff --git a/reftable/merged.h b/reftable/merged.h > > index 89bd0c4b35b..13a5fe4154e 100644 > > --- a/reftable/merged.h > > +++ b/reftable/merged.h > > @@ -10,11 +10,12 @@ license that can be found in the LICENSE file or at > > #define MERGED_H > > > > #include "system.h" > > +#include "basics.h" > > Naive question, being that "merged.h" only depends on > `reftable-basics.h:reftable_hash` and not any of the internal reftable > basics components, would it be best to instead reference it directly? Or > because "merged.h" is also internal do we also prefer to use the > internal "basics.h"? > > Probably doesn't really matter, but I was just curious if there was any > reasoning. :) Not really, let's do as you propose. Patrick
