Re: [PATCH] t6300: values containing ')' are broken in ref formats

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 06, 2024 at 09:24:08AM +0530, Kousik Sanagavarapu wrote:

> One way to fix this is refactoring the way in which we parse our format
> string.  Although this would mean we would have to do a huge refactoring
> as this step happens very high up in the call chain.
> 
> Therefore, support including parenthesis characters in "<string>" by
> instead giving their hexcode equivalents - as a for-now hack.

So if I understand this is just expanding %<hex> and nothing else? That
seems like the worst of both worlds. Now "%" is magic in these value
strings, breaking compatibility, but we didn't buy ourselves the
flexibility to do arbitrary comparisons like:

  %(if:equals=%(upstream:lstrip=3))%(refname:short)%(then)...

-Peff




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux