Re: [PATCH v5 1/6] fetch-pack: refactor packet writing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v5 1/6] fetch-pack: refactor packet writing
From: Junio C Hamano <gitster@xxxxxxxxx>
Date: Tue, 05 Nov 2024 17:06:31 -0800
Cc: Eric Ju <eric.peijian@xxxxxxxxx>, git@xxxxxxxxxxxxxxx, calvinwan@xxxxxxxxxx, jonathantanmy@xxxxxxxxxx, chriscool@xxxxxxxxxxxxx, karthik.188@xxxxxxxxx, toon@xxxxxxxxx, jltobler@xxxxxxxxx
Feedback-id: if26b431b:Fastmail
In-reply-to: <CAP8UFD0Yk1Twv9DMOYwO4R+7P0YHj1CgK8xN=2YdE8sdi4ukow@mail.gmail.com> (Christian Couder's message of "Tue, 5 Nov 2024 18:44:29 +0100")
References: <20240628190503.67389-1-eric.peijian@gmail.com> <20241028203457.19715-1-eric.peijian@gmail.com> <20241028203457.19715-2-eric.peijian@gmail.com> <CAP8UFD0Yk1Twv9DMOYwO4R+7P0YHj1CgK8xN=2YdE8sdi4ukow@mail.gmail.com>
User-agent: Gnus/5.13 (Gnus v5.13)

Christian Couder <christian.couder@xxxxxxxxx> writes:

> It looks like other patches in the series, like patch 4/6, have
> similar issues. Otherwise the other patches in the series look good to
> me.

Thanks for a review.

Follow-Ups:
- Re: [PATCH v5 1/6] fetch-pack: refactor packet writing
  - From: Peijian Ju

References:
- [PATCH 0/6] cat-file: add remote-object-info to batch-command
  - From: Eric Ju
- [PATCH v5 0/6] cat-file: add remote-object-info to batch-command
  - From: Eric Ju
- [PATCH v5 1/6] fetch-pack: refactor packet writing
  - From: Eric Ju
- Re: [PATCH v5 1/6] fetch-pack: refactor packet writing
  - From: Christian Couder

Prev by Date: Re: [Question] How to force relative path output when using `git status --porcelain=2 -z`
Next by Date: Re: [PATCH] t6300: values containing ')' are broken in ref formats
Previous by thread: Re: [PATCH v5 1/6] fetch-pack: refactor packet writing
Next by thread: Re: [PATCH v5 1/6] fetch-pack: refactor packet writing
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]