Hey. On Mon, 2024-11-04 at 16:22 -0800, Junio C Hamano wrote: > ... this falls squarely into "if it hurts, don't do it" category. I rather thought it would be the category "if it's a bug, that is completely non-obvious and not really to expect, with not even a warning in place,... it should better be fixed" ;-) There is not reason for any commit author to assume that these strings are not valid, or possibly cause later breakage. Even if so, it seems not really feasible to know any possible strings, especially when people might just copy&paste output from others into their commit message. To the least there should be an error when format-patch creates a one that cannot be parsed afterwards. And a proper solution would employ some form of escaping. And if one's on the other side, and wants to write a parser, one has no real chance of assuring that only "valid" input is used by users in a commit message. One can easily imagine hat this could accidentally (or intentionally) be used apply undesired patches. Cheers, Chris.
